-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More docs for merge! #23495
Merged
Merged
More docs for merge! #23495
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,6 +111,29 @@ function ffmerge!(repo::GitRepo, ann::GitAnnotated) | |
end | ||
|
||
# Merge changes into current head | ||
""" | ||
merge!(repo::GitRepo, anns::Vector{GitAnnotated}; kwargs...) -> Bool | ||
|
||
Merge changes from the annotated commits (captured as [`GitAnnotated`](@ref) objects) | ||
`anns` into the HEAD of the repository `repo`. The keyword arguments are: | ||
* `merge_opts::MergeOptions = MergeOptions()`: options for how to perform the merge, | ||
including whether fastforwarding is allowed. See [`MergeOptions`](@ref) for more | ||
information. | ||
* `checkout_opts::CheckoutOptions = CheckoutOptions()`: options for how to perform | ||
the checkout. See [`CheckoutOptions`](@ref) for more information. | ||
|
||
`anns` may refer to remote or local branch heads. Return `true` if the merge is | ||
successful, otherwise return `false` (for instance, if no merge is possible | ||
because the branches have no common ancestor). | ||
|
||
# Examples | ||
```julia | ||
upst_ann = LibGit2.GitAnnotated(repo, "branch/a") | ||
|
||
# merge the branch in | ||
LibGit2.merge!(repo, [upst_ann]) | ||
``` | ||
""" | ||
function merge!(repo::GitRepo, anns::Vector{GitAnnotated}; | ||
merge_opts::MergeOptions = MergeOptions(), | ||
checkout_opts::CheckoutOptions = CheckoutOptions()) | ||
|
@@ -126,6 +149,40 @@ end | |
|
||
# Internal implementation of merge. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same with these |
||
# Returns `true` if merge was successful, otherwise `false` | ||
""" | ||
merge!(repo::GitRepo, anns::Vector{GitAnnotated}, fastforward::Bool; kwargs...) -> Bool | ||
|
||
Merge changes from the annotated commits (captured as [`GitAnnotated`](@ref) objects) | ||
`anns` into the HEAD of the repository `repo`. If `fastforward` is `true`, *only* a | ||
fastforward merge is allowed. In this case, if conflicts occur, the merge will fail. | ||
Otherwise, if `fastforward` is `false`, the merge may produce a conflict file which | ||
the user will need to resolve. | ||
|
||
The keyword arguments are: | ||
* `merge_opts::MergeOptions = MergeOptions()`: options for how to perform the merge, | ||
including whether fastforwarding is allowed. See [`MergeOptions`](@ref) for more | ||
information. | ||
* `checkout_opts::CheckoutOptions = CheckoutOptions()`: options for how to perform | ||
the checkout. See [`CheckoutOptions`](@ref) for more information. | ||
|
||
`anns` may refer to remote or local branch heads. Return `true` if the merge is | ||
successful, otherwise return `false` (for instance, if no merge is possible | ||
because the branches have no common ancestor). | ||
|
||
# Examples | ||
```julia | ||
upst_ann_1 = LibGit2.GitAnnotated(repo, "branch/a") | ||
|
||
# merge the branch in, fastforward | ||
LibGit2.merge!(repo, [upst_ann_1], true) | ||
|
||
# merge conflicts! | ||
upst_ann_2 = LibGit2.GitAnnotated(repo, "branch/b") | ||
# merge the branch in, try to fastforward | ||
LibGit2.merge!(repo, [upst_ann_2], true) # will return false | ||
LibGit2.merge!(repo, [upst_ann_2], false) # will return true | ||
``` | ||
""" | ||
function merge!(repo::GitRepo, anns::Vector{GitAnnotated}, fastforward::Bool; | ||
merge_opts::MergeOptions = MergeOptions(), | ||
checkout_opts::CheckoutOptions = CheckoutOptions()) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment seem a bit superfluous now that we have a complete docstring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they aren't harming anyone by hanging around. In general I'd rather err on the side of having more context rather than less...