Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove authentication failure protection counter #23575

Merged
merged 1 commit into from
Sep 9, 2017
Merged

Remove authentication failure protection counter #23575

merged 1 commit into from
Sep 9, 2017

Conversation

omus
Copy link
Member

@omus omus commented Sep 4, 2017 •
edited
Loading

State between multiple credential_callback calls is now being maintained within the CredentialPayload. The removal of the authentication failure protection count produces the following changes:

  • Authentication no longer spams remote servers by sending invalid credentials three times
  • Improved readability
  • Credential types no longer need to track number of times used
  • Removes checkused! function
  • Removes reset!(::AbstractCredentials) methods
  • CachedCredentials is no longer required to be mutable

@omus omus added the libgit2 The libgit2 library or the LibGit2 stdlib module label Sep 4, 2017
@kshyatt kshyatt mentioned this pull request Sep 4, 2017
Closed
@omus
Copy link
Member Author

omus commented Sep 4, 2017

Part of #20725

@omus
Remove authentication failure protection counter
26014f9 
State between multiple credential_callback calls is now being maintained
within the `CredentialPayload`. This change allows credential types to
just contain credential information.
@omus omus mentioned this pull request Sep 8, 2017
Merged
@omus
Copy link
Member Author

omus commented Sep 9, 2017

Will merge tomorrow.

@omus omus merged commit 7e143bb into master Sep 9, 2017
@omus omus deleted the cv/libgit2-fail-count branch September 9, 2017 20:19
omus added a commit that referenced this pull request Sep 9, 2017
@omus
Remove unused LibGit2 methods
131a619 
These methods were supposed to be removed in #23575
@omus omus mentioned this pull request Sep 9, 2017
Merged
omus added a commit that referenced this pull request Sep 10, 2017
@omus
Remove unused LibGit2 methods
4cd3cf8 
These methods were supposed to be removed in #23575
@omus omus mentioned this pull request Sep 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@omus