-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] More flexible and convenient logging #23712
Commits on Oct 25, 2017
-
Copy of MicroLogging source (656f937) exports + sysimg
Some minor edits here to make things suitable for Base.
Configuration menu - View commit details
-
Copy full SHA for 283eb49 - Browse repository at this point
Copy the full SHA 283eb49View commit details -
More backend interface renaming
Use handle_message rather than dispatch_message, as not all message handling is pure dispatch (the message may be stored rather than sent elsewhere). Reuse the name dispatch_message internally.
Configuration menu - View commit details
-
Copy full SHA for 99e682c - Browse repository at this point
Copy the full SHA 99e682cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b7c697 - Browse repository at this point
Copy the full SHA 9b7c697View commit details -
Configuration menu - View commit details
-
Copy full SHA for d81e6d0 - Browse repository at this point
Copy the full SHA d81e6d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bd2397 - Browse repository at this point
Copy the full SHA 0bd2397View commit details -
Migrate depwarn to new logging infrastructure
* Forward depwarn() calls to new backend * Use caller frame pointer as message id. This makes initial first-pass deduplication of depwarns quite a lot faster. * Change --depwarn=error to --depwarn=throw for clarity * Introduce defines for log levels into julia.h
Configuration menu - View commit details
-
Copy full SHA for 0b8a7fc - Browse repository at this point
Copy the full SHA 0b8a7fcView commit details -
Forward all frontend depwarns to the logging system
Forward all frontend depwarn messages through to the julia logging system for consistency of formatting and dispatch. Deciding whether a depwarn should appear as an thrown error is also now handled outside flisp to keep this decision in one place where possible. Detail: * Ensure that deprecation-message forwards to the logging system. Also include file and line number metadata * Remove jl_parse_depwarn(), flisp *depwarn* and related scheme code as this can be handled on the julia side. * Rename syntax_deprecation_warnings(false) to without_syntax_deprecations, as this was only ever used to turn syntax deprecations off. * Ensure that all lowering depwarns with existing line number information get this passed through as accessible metadata rather than as a string. * Use distinct functions for depwarns coming from the parser vs lowering, as these get line number information in a different way. TODO: * Figure out a decent `id` for the syntax and lowering depwarn messages * Make without_syntax_deprecations filter only depwarn messages, rather than everything!
Configuration menu - View commit details
-
Copy full SHA for b747fe5 - Browse repository at this point
Copy the full SHA b747fe5View commit details -
Changes ported from MicroLogging
* Additional exports * Fallback error message formatting * Minor global logger init min level bug
Configuration menu - View commit details
-
Copy full SHA for 0e52ef1 - Browse repository at this point
Copy the full SHA 0e52ef1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7798ee - Browse repository at this point
Copy the full SHA e7798eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e062426 - Browse repository at this point
Copy the full SHA e062426View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40f8697 - Browse repository at this point
Copy the full SHA 40f8697View commit details
Commits on Oct 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9fd7e73 - Browse repository at this point
Copy the full SHA 9fd7e73View commit details
Commits on Oct 30, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 7bdf93c - Browse repository at this point
Copy the full SHA 7bdf93cView commit details -
Move core Logging components into Base
For now this seems like the right thing as error and informational reporting is a core requirement for a compiler - parts of the frontend and runtime now call the logging system when it's available.
Configuration menu - View commit details
-
Copy full SHA for d0f143a - Browse repository at this point
Copy the full SHA d0f143aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 544c6b9 - Browse repository at this point
Copy the full SHA 544c6b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b674a36 - Browse repository at this point
Copy the full SHA b674a36View commit details
Commits on Nov 1, 2017
-
Logging tools for use in the runtime C code
These can be used to transform a lot of printf()'s into log statements.
Configuration menu - View commit details
-
Copy full SHA for be777bc - Browse repository at this point
Copy the full SHA be777bcView commit details
Commits on Nov 2, 2017
-
Add catch_exceptions(::AbstractLogger)
This allows users to control whether a custom logger type will catch exceptions during message creation and log them, or simply allow them to pass through.
Configuration menu - View commit details
-
Copy full SHA for 7ed4de5 - Browse repository at this point
Copy the full SHA 7ed4de5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 757c92c - Browse repository at this point
Copy the full SHA 757c92cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58fb9e7 - Browse repository at this point
Copy the full SHA 58fb9e7View commit details -
Implement general julia-logmsg function for flisp logging
Provides a general tool to log information from the flisp frontend code. Make the syntax deprecations use this instead of using the purpose built syntax_depwarn function on the julia side. Also reinstate flisp-level awareness of the depwarn level. It's just simpler.
Configuration menu - View commit details
-
Copy full SHA for 34bd483 - Browse repository at this point
Copy the full SHA 34bd483View commit details -
Change log level limits to fit well within a flisp fixnum
This is purely for implementation convenience. It restricts the levels artifically, but it's hard to imagine what anyone would do with more than a million custom levels.
Configuration menu - View commit details
-
Copy full SHA for a127e3f - Browse repository at this point
Copy the full SHA a127e3fView commit details -
Remove all uses of --depwarn=error
This can be handled in a much nicer way by installing a logger in-process. TODO: Define such a logger and test it!
Configuration menu - View commit details
-
Copy full SHA for ee8bb6e - Browse repository at this point
Copy the full SHA ee8bb6eView commit details
Commits on Nov 3, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 483c771 - Browse repository at this point
Copy the full SHA 483c771View commit details
Commits on Nov 4, 2017
-
Rearrange logging source into a more logical order
Port from MicroLogging refactoring Also rearrange exports to avoid exporting AbstractLogger-related methods.
Configuration menu - View commit details
-
Copy full SHA for bd6a3ae - Browse repository at this point
Copy the full SHA bd6a3aeView commit details
Commits on Nov 5, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 8319628 - Browse repository at this point
Copy the full SHA 8319628View commit details