Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparsity-preserving outer products #24980

Merged
merged 7 commits into from
Jan 7, 2019
Merged

Sparsity-preserving outer products #24980

merged 7 commits into from
Jan 7, 2019

Commits on Jan 5, 2019

  1. Add indtype and nnz definitions for SparseColumnView

    @jmert
    jmert committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    a1d0d9b View commit details
    Browse the repository at this point in the history

  2. Handle sparse outer products specially in broadcast

    @jmert
    jmert committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    f9a6634 View commit details
    Browse the repository at this point in the history

  3. Add specialized kron for sparse outer products

    @jmert
    jmert committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    6d27803 View commit details
    Browse the repository at this point in the history

  4. Add tests

    @jmert
    jmert committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    945bdbb View commit details
    Browse the repository at this point in the history

  5. Support unitful types

    @jmert
    jmert committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    16fac74 View commit details
    Browse the repository at this point in the history

  6. Address review comments. 

    * Change is_specialcase_sparse_broadcast -> can_skip_sparsification.
* Lift parent(y) to one function earlier for clarify
    @jmert
    jmert committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    26ed753 View commit details
    Browse the repository at this point in the history

  7. Simply call _copy instead of passing through the broadcast machinery … 

    …again
    @jmert
    jmert committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    9bec023 View commit details
    Browse the repository at this point in the history