Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all use of 'indexes' with 'indices' #25088

Merged
merged 1 commit into from
Dec 16, 2017
Merged

Conversation

ararslan
Copy link
Member

This changes all use of "indexes" as a noun to "indices," which is the proper pluralization of "index." Functions which use indexes as part of the name, e.g. parentindexes and localindexes, have been deprecated accordingly. The only possibly breaking change here is that field names that use indexes have been changed, so code that specifically tries to access such a field will break without a deprecation.

Fixes #12902.

@ararslan ararslan added breaking This change will break code deprecation This change introduces or involves a deprecation labels Dec 14, 2017
@ararslan ararslan added this to the 1.0 milestone Dec 14, 2017
@ararslan ararslan requested a review from Sacha0 December 14, 2017 23:55
@ararslan ararslan added the needs news A NEWS entry is required for this change label Dec 15, 2017
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially lgtm! :)

(I lack a strong opinion about these replacements generally.)

@ararslan ararslan removed the needs news A NEWS entry is required for this change label Dec 15, 2017
@ararslan ararslan merged commit c640381 into master Dec 16, 2017
@ararslan ararslan deleted the aa/indices-everywhere branch December 16, 2017 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change will break code deprecation This change introduces or involves a deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants