Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <(::Tuple, ::Tuple) implementing three-valued logic #25099

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Conversation

nalimilan
Copy link
Member

For consistency with ==, as < was the only remaining exception.
isless still returns a Bool, treating missing as greater than any other value.

I should have fixed that at the same time as #24963.

For consistency with ==, as < was the only remaining exception.
isless() still returns a Bool, treating missing as greater than any other value.
@nalimilan nalimilan added the missing data Base.missing and related functionality label Dec 15, 2017
@andyferris
Copy link
Member

Do we have a lexical ordering comparitor for iterables collections?

@nalimilan
Copy link
Member Author

We have lexcmp and lexless (which do not implement 3VL, like isless).

@nalimilan
Copy link
Member Author

@StefanKarpinski OK for this one too? Should be the last of the 3VL series.

@StefanKarpinski
Copy link
Sponsor Member

Yes, that's good to go. I'm still planning on deprecating lexless as described in #5290.

@andyferris
Copy link
Member

OK, so out of curiosity: the plan is to support lexical ordering for < and isless for tuples only? Or for basically any iterable?

@StefanKarpinski
Copy link
Sponsor Member

I was not going to do any iterable, but any abstract array seems reasonable.

@nalimilan nalimilan merged commit ff0e1f7 into master Dec 15, 2017
@nalimilan nalimilan deleted the nl/cmp branch December 15, 2017 23:34
@andyferris
Copy link
Member

any abstract array seems reasonable.

I wonder if NamedTuples and AbstractDicts that share an iteration order might also make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing data Base.missing and related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants