fill[stored]! for Symmetric and Hermitian matrices #25152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
reviewed
Dec 18, 2017
base/linalg/symmetric.jl
Outdated
| # fill[stored]! | ||
| function fill!(A::HermOrSym{T}, x) where T | ||
| xT = convert(T, x) | ||
| if !iszero(xT) |
There was a problem hiding this comment.
I imagine I miss something: A general symmetric matrix can be homogeneously populated with any value, and a general hermitian matrix with any real value?
Sacha0
reviewed
Dec 18, 2017
base/linalg/symmetric.jl
Outdated
| fillband!(A.data, x, 1-size(A,1), 0) | ||
| end | ||
| return A | ||
| end |
There was a problem hiding this comment.
For the hermitian case the fill value must be real IIUC?
fredrikekre
force-pushed
the
fe/more-fillstored
branch
2 times, most recently
from
8416f3e
to
447307a
Compare
fredrikekre
force-pushed
the
fe/more-fillstored
branch
from
447307a
to
a3ea13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #17670 and #25030