Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depwarn caller fix #25158

Merged
merged 2 commits into from
Dec 21, 2017
Merged

Depwarn caller fix #25158

merged 2 commits into from
Dec 21, 2017

Conversation

c42f
Copy link
Member

@c42f c42f commented Dec 18, 2017

This fixes the core problem of #25130, namely that on occasion - and especially at top level scope - the internal dispatch or interpreter machinery was being blamed as the caller of a deprecated function.

Along the way I also noticed what was arguably a bug in global_logger(logger), so that's also fixed to more usefully return the old logger rather than the replacement.

@ararslan ararslan added bugfix This change fixes an existing bug logging The logging framework labels Dec 19, 2017
@c42f
Copy link
Member Author

c42f commented Dec 19, 2017

CI failure seems unrelated... if potentially serious

      From worker 8:	julia: /home/circleci/project/deps/srccache/llvm-3.9.1/lib/MC/MCContext.cpp:118: llvm::MCSymbol* llvm::MCContext::getOrCreateSymbol(const llvm::Twine&): Assertion `!NameRef.empty() && "Normal symbols cannot be unnamed!"' failed.
      From worker 8:	
      From worker 8:	signal (6): Aborted

@StefanKarpinski
Copy link
Sponsor Member

cc @vtjnash ^

@c42f
Copy link
Member Author

c42f commented Dec 21, 2017

Can this be merged? It's a small bugfix, CI has passed, and I want to build some other things on top of it.

@StefanKarpinski
Copy link
Sponsor Member

Should I squash or not?

@c42f
Copy link
Member Author

c42f commented Dec 21, 2017

I think not, the two commits here represent distinct changes.

@StefanKarpinski StefanKarpinski merged commit f9e2d99 into JuliaLang:master Dec 21, 2017
@c42f c42f deleted the depwarn-caller-fix branch January 14, 2018 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug logging The logging framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants