Logging depwarn cleanup #25239
Merged
Logging depwarn cleanup #25239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Temporariliy reinstate redirection for Base.display_error(). Uses of this (via logging(..., kind=:error)) will get a depwarn via the logging() function. * Move tests of deprecated functionality to deprecation_exec, so that they'll be executed without --depwarn=error
|
This is passing tests so feel free to merge when you feel it's ready! |
c42f
commented
Dec 22, 2017
| if !isempty(st) | ||
| io = redirect(io, log_error_to, st[1]) | ||
| end | ||
| end |
There was a problem hiding this comment.
@stevengj by the way, here's an answer to your question about log_error_to - for the moment I've reinstated it exactly as it was used inside display_error. I think it was a bit of a misfeature if used to capture REPL errors, but it's easy to preserve the behavior for now.
There was a problem hiding this comment.
The point is, this will get removed when the deprecation is removed in 1.0, right?
There was a problem hiding this comment.
Right. The user should get a depwarn if they ever manage to populate log_error_to.
|
Cheers! This was a relatively minor cleanup so I went ahead and merged it without further ado. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup mostly to address problems @stevengj found over at 5d77d1b#r26334167
I also added some license headers which I realized were forgotten from the original PR.
Potentially replaces #25229