preserve sign of NaN in conversions to and from BigFloat #25378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at #5290 led me to finding various issues with the sign bit of NaN, which, let's be honest, is basically what most issues boil down to.
I don't know if this really matters, but our other floating point conversions preserve the sign of NaN so I figure these should too. Currently we get e.g.:
Maybe this is a bug in MPFR; not sure.