Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search and find* deprecations fixes and improvements #26149

Merged
merged 3 commits into from
Mar 7, 2018
Merged

Search and find* deprecations fixes and improvements #26149

merged 3 commits into from
Mar 7, 2018

Commits on Mar 7, 2018

  1. Fix search and find* deprecations to return 0 instead of nothing 

    The current behavior breaks backward compatibility.
    @nalimilan
    nalimilan committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    4ad7e8c View commit details
    Browse the repository at this point in the history

  2. Remove two incorrect rsearch deprecations 

    We do not provide any replacement for these methods which have never been documented.
    @nalimilan
    nalimilan committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    da7aaa8 View commit details
    Browse the repository at this point in the history

  3. Change find* methods to return nothing instead of than empty ranges f… 

    …or no match

This is more consistent with functions which return a single index. It also allows
distinguishing no match from an empty match.
    @nalimilan
    nalimilan committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    f763e38 View commit details
    Browse the repository at this point in the history