Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computation of sparse BroadcastStyle dimensionality #26978

Merged
merged 1 commit into from
May 5, 2018

Conversation

mbauman
Copy link
Sponsor Member

@mbauman mbauman commented May 4, 2018

when falling back to a DefaultArrayStyle for array types that are not included in the support for PromoteToSparse. Fixes #26977

when falling back to a DefaultArrayStyle for array types that are not included in the support for PromoteToSparse. Fixes #26977
@mbauman mbauman added broadcast Applying a function over a collection sparse Sparse arrays bugfix This change fixes an existing bug labels May 4, 2018
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great assuming CI approves! Thanks Matt! :)

@mbauman
Copy link
Sponsor Member Author

mbauman commented May 4, 2018

Mac failure is #26725. 64 bit Windows is a timeout.

@fredrikekre fredrikekre merged commit 2cab814 into master May 5, 2018
@fredrikekre fredrikekre deleted the mb/demotetosparse branch May 5, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Applying a function over a collection bugfix This change fixes an existing bug sparse Sparse arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants