Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen,coverage: handle inlining info #30251

Merged
merged 1 commit into from
Dec 5, 2018
Merged

codegen,coverage: handle inlining info #30251

merged 1 commit into from
Dec 5, 2018

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Dec 3, 2018

Previously, we were just blindly ignoring inlined_at information.
This worked out usually OK with inlining disabled,
but missed a lot of potentially good information otherwise,
likely contributing to #28192.

@vtjnash
codegen,coverage: handle inlining info
4bc155a 
Previously, we were just blindly ignoring inlined_at information.
This worked out usually OK with inlining disabled,
but missed a lot of potentially good information otherwise,
likely contributing to #28192.
@vtjnash vtjnash mentioned this pull request Dec 3, 2018
Closed
@KristofferC
Copy link
Sponsor Member

Backportable?

@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Dec 3, 2018

probably. it's all pretty internal changes

vchuravy
vchuravy reviewed Dec 3, 2018
View reviewed changes
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also mean we provide better DI to LLVM?

src/codegen.cpp Show resolved Hide resolved
@kshyatt kshyatt added the compiler:codegen Generation of LLVM IR and native code label Dec 4, 2018
@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Dec 4, 2018

This doesn't alter the DI information

@vtjnash vtjnash merged commit 2b0fec6 into master Dec 5, 2018
@vtjnash vtjnash deleted the jn/re-coverage branch December 5, 2018 01:30
@KristofferC KristofferC mentioned this pull request Dec 6, 2018
Merged
61 tasks
@KristofferC KristofferC mentioned this pull request Dec 30, 2018
Closed
53 tasks
@tkoolen tkoolen mentioned this pull request Jan 26, 2019
Closed
@StefanKarpinski StefanKarpinski added triage This should be discussed on a triage call backport 1.0 and removed triage This should be discussed on a triage call labels Jan 31, 2019
@KristofferC
Copy link
Sponsor Member

Doesn't seem like the backport will happen so removing label.

@KristofferC KristofferC removed backport 1.0 triage This should be discussed on a triage call labels Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy left review comments

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vtjnash @KristofferC @vchuravy @StefanKarpinski @kshyatt