Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-Function args to retry #30382

Merged
merged 7 commits into from
Feb 12, 2019
Merged

Allow non-Function args to retry #30382

merged 7 commits into from
Feb 12, 2019

Conversation

simonbyrne
Copy link
Contributor

I hit this while trying to use a PyObject

I hit this while trying to use a `PyObject`
@ararslan ararslan added needs tests Unit tests are required for this change needs news A NEWS entry is required for this change labels Dec 13, 2018
@simonbyrne
Copy link
Contributor Author

simonbyrne commented Dec 13, 2018

@ararslan it should already be tested. Or is there a standard way for testing "works with a callable non-Function"?

@ararslan
Copy link
Member

I dunno, just try passing something that isn't a function (like e.g. a type) and see what happen?

@ararslan ararslan removed the needs news A NEWS entry is required for this change label Dec 13, 2018
@ararslan ararslan removed the needs tests Unit tests are required for this change label Dec 14, 2018
@fredrikekre
Copy link
Member

Add

!!! compat "Julia 1.2"
    Before Julia 1.2 this signature was restricted to `f::Function`.

before the examples in the docstring?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants