fix #30643, correctly propagate iterator traits through Stateful #30644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what the previous definition of IteratorSize was trying to do, but it was wrong for IsInfinite. Not sure what the correct answer is for HasShape.
StefanKarpinski
requested review from
Keno,
nalimilan,
StefanKarpinski and
JeffBezanson
and removed request for
Keno and
StefanKarpinski
|
Anyone have a good test case for this? |
|
julia> Base.IteratorSize(Iterators.Stateful(Iterators.cycle(1:10)))
Base.HasLength()
This should be IsInfinite().
…On Tue, Jan 8, 2019 at 9:49 AM Stefan Karpinski ***@***.***> wrote:
Anyone have a good test case for this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30644 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvNpkwe7fG6arewwVciyuLYctBtjaObks5vBK_xgaJpZM4Z0x6r>
.
|
|
Could you add that test to test/iterators.jl? |
Keno
reviewed
Jan 8, 2019
| @@ -1089,10 +1089,9 @@ end | |||
|
|
|||
| @inline peek(s::Stateful, sentinel=nothing) = s.nextvalstate !== nothing ? s.nextvalstate[1] : sentinel | |||
| @inline iterate(s::Stateful, state=nothing) = s.nextvalstate === nothing ? nothing : (popfirst!(s), nothing) | |||
| IteratorSize(::Type{Stateful{VS,T}} where VS) where {T} = | |||
There was a problem hiding this comment.
I don't quite remember what the intent here was, but it may have been to filter out HasSize, since we don't pass that through (and can't really support).
|
So Stateful should change HasSize to HasLength?
…On Tue, Jan 8, 2019, 1:42 PM Keno Fischer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In base/iterators.jl
<#30644 (comment)>:
> @@ -1089,10 +1089,9 @@ end
@inline peek(s::Stateful, sentinel=nothing) = s.nextvalstate !== nothing ? s.nextvalstate[1] : sentinel
@inline iterate(s::Stateful, state=nothing) = s.nextvalstate === nothing ? nothing : (popfirst!(s), nothing)
-IteratorSize(::Type{Stateful{VS,T}} where VS) where {T} =
I don't quite remember what the intent here was, but it may have been to
filter out HasSize, since we don't pass that through (and can't really
support).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30644 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvNpitwt1pb6d4aUmRkN4aWUzXArQUIks5vBOaEgaJpZM4Z0x6r>
.
|
|
Yeah, I think that's right. |
mbauman
changed the title
|
Should be backported? |
|
Yes. |
KristofferC
pushed a commit
that referenced
this pull request
Jan 11, 2019
StefanKarpinski
added
triage
StefanKarpinski
added
backport 1.0
triage
KristofferC
pushed a commit
that referenced
this pull request
Feb 4, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 4, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
KristofferC
pushed a commit
that referenced
this pull request
Apr 20, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the previous definition of IteratorSize was trying to do, but it was wrong for IsInfinite. Not sure what the correct answer is for HasShape.