Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different invalid SSAValue for unexpected initial_incoming_vals #31786

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

oxinabox
Copy link
Contributor

@oxinabox oxinabox commented Apr 21, 2019

There are two conditions for which we use negative SSAValues,
to trigger errors later if those values get used.

I figure we might as well make those different values,
because that will make debugging anything that goes wrong easier.

I say this after thinking I was debugging one kind of error, but I was actually debugging another.

Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible. In the fullness of time we should have the verifier catch these things.

@vchuravy
Copy link
Member

Should have some kind of test + documentation

@Keno
Copy link
Member

Keno commented Apr 21, 2019

We don't generally do either for internal assertions, which is essentially what this is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants