Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename test/bigint.jl to test/gmp.jl #31992

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

rfourquet
Copy link
Member

For consistency with base/gmp.jl and test/mpfr.jl.

See #29144 (comment).

@rfourquet rfourquet added bignums BigInt and BigFloat needs pkgeval Tests for all registered packages should be run with this change test This change adds or pertains to unit tests and removed needs pkgeval Tests for all registered packages should be run with this change labels May 10, 2019
@fredrikekre
Copy link
Member

Need to update bigint to gmp here:

"operators", "path", "ccall", "parse", "loading", "bigint",

@rfourquet
Copy link
Member Author

Ah yeah thanks, I just realised too!

@StefanKarpinski
Copy link
Sponsor Member

I wonder if we shouldn't change in the other direction—use bigint and bigfloat in base and test.

@rfourquet
Copy link
Member Author

I wonder if we shouldn't change in the other direction—use bigint and bigfloat in base and test.

This makes a lot of sense to me. On the other hand, it's somewhat practical to have the filenames reflect the name of the contained modules.

@StefanKarpinski
Copy link
Sponsor Member

On the other hand, it's somewhat practical to have the filenames reflect the name of the contained modules.

We could change the names of those modules too. If breaking code that reaches into them is a concern, we could just do const GMP = BigInts right after the module is defined.

@rfourquet rfourquet added the triage This should be discussed on a triage call label May 28, 2019
@JeffBezanson
Copy link
Sponsor Member

I think we should merge this. If somebody wants to do the renaming the other way (gmp -> bigint) they can, but in the meantime the filenames will be more consistent.

For consistency with base/gmp.jl and test/mpfr.jl.
@rfourquet
Copy link
Member Author

I realize this was a bit silly of me to add the triage label, I will just merge when CI is green as Jeff suggested.

@rfourquet rfourquet removed the triage This should be discussed on a triage call label Nov 15, 2019
@rfourquet rfourquet merged commit ee3c88b into master Nov 15, 2019
@rfourquet rfourquet deleted the rf/rename-test-bigint.jl branch November 15, 2019 20:58
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
For consistency with base/gmp.jl and test/mpfr.jl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bignums BigInt and BigFloat test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants