fix test for sparse matrix assignment #32756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
pushed a commit
that referenced
this pull request
Aug 5, 2019
(cherry picked from commit 30b3636)
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
(cherry picked from commit 30b3636)
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
(cherry picked from commit 30b3636)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit 30b3636)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "test" was introduced in #30405, but (i) it doesn't test anything, and (ii) what was written returns false. Judging from #30006, I guess what was supposed to be tested is assignment to previous zero elements, not comparison. Anyway, please feel free to change to whatever is more meaningful.
Edit: those patches were backported, so this may apply here as well?