-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 32690 : SSHManager with csh shell #32765
Conversation
@amitmurthy do you want to review this? |
@tanmaykm Can you review and merge this? I don't fully understand the intricacies of |
cd -- $(shell_escape_posixly(dir)) | ||
$(isempty(tval) ? "" : "export JULIA_WORKER_TIMEOUT=$(shell_escape_posixly(tval))") | ||
$(shell_escape_posixly(exename)) $(shell_escape_posixly(exeflags))""" | ||
cmds = """cd -- $(shell_escape_posixly(dir)) ; $(isempty(tval) ? "" : "export JULIA_WORKER_TIMEOUT=$(shell_escape_posixly(tval))") $(shell_escape_posixly(exename)) $(shell_escape_posixly(exeflags))""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If multiple lines were merged, shouldn't there be a command separator after all the lines? I don't see one after the second line.
Since this is quite old, it will be good to rebase this once with master. We probably do not run our CI tests with |
fixes #32690 |
@tanmaykm you can do something like However, that will make all shells spawned with Is there a proper place where we can set-and-unset |
Dear Julia team,
A pull request from issue 32690
Best regards