Automatically up-convert eltype in SPQR #33601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib/SuiteSparse/src/spqr.jl
Outdated
| "sparse floating point QR using SPQR or qr(Array(A)) for generic ", | ||
| "dense QR."))) | ||
| LinearAlgebra.qr(A::SparseMatrixCSC; tol=_default_tol(A)) = qr(float(A); tol=tol) | ||
| # function LinearAlgebra.qr(A::SparseMatrixCSC; tol=_default_tol(A)) |
There was a problem hiding this comment.
Should this one be deleted?
There was a problem hiding this comment.
Yes, this was just a placeholder in case we decide not to upconvert but to error. I'll delete this then and merge.
andreasnoack
approved these changes
Nov 12, 2019
|
I'll also add a short comment to the !!!note docstring, something like Or any other suggestion? |
dkarrasch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to close #33425, one way or another.
I realized that we do up-convert in the other two sparse factorizations, UMFPACK and CHOLMOD, and this is clearly documented. So one option is to do the same with SPQR. Another option that we discussed over at #33425 is to throw an error message.
The previous line below the docstring was calling a non-existent method, so I moved the main workhorse below the docstring, adapted the conversion functions from UMFPACK, and added a "!!! note" (maybe it should be a compat annotation?).