add missing constructor for ReverseOrdering() and tidy sort tests #33736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
commented
Nov 1, 2019
| @test_throws ArgumentError sortperm!(view([1,2,3,4], 1:4), [2,3,1]) | ||
| end | ||
|
|
||
| @testset "misc sorting" begin |
There was a problem hiding this comment.
I am not extatic about this testsets name.
Should I just take these back out and maybe put them at the top?
oxinabox
commented
Nov 1, 2019
| @@ -27,11 +27,12 @@ end | |||
|
|
|||
| ReverseOrdering(rev::ReverseOrdering) = rev.fwd | |||
| ReverseOrdering(fwd::Fwd) where {Fwd} = ReverseOrdering{Fwd}(fwd) | |||
| ReverseOrdering() = ReverseOrdering(ForwardOrdering()) | |||
There was a problem hiding this comment.
This is the focus of this PR
oxinabox
force-pushed
the
ox/orderrevdef
branch
from
f32d114
to
69167a7
Compare
|
Bump |
oxinabox
changed the title
|
@kmsquire can you take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in JuliaCollections/DataStructures.jl#547
It seems natural that we should have a zero argument constructor for
ReverseOrderingthat matchs to the
Reverseconstant.Yes, there are other orderings one might want to reverse,
but this is the default one,
and it would be nice to be able to construct it from the type alone.
When I went to add tests I saw the sorting tests were not testing ordering much,
and also were not fully in testsets, so I fixed that