-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force patchelf
to use 64KB page size on aarch64/powerpc64le
#33745
Conversation
Fixes #33293 (we think). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo the syntax error CI complains about.
This fixes problems with binaries on these two platforms that often use these large page sizes.
fb2cc76
to
5ceed92
Compare
I'm happy to test on an aarch64 machine with big pages once we have a tarball with this fix. |
To be clear; we still need to fix all the deps, but at least |
No dice:
|
That seems to have done it (for the gcc runtime libraries at least):
|
Fantastic. I'll merge this, then open PRs for pieces such as |
This fixes problems with binaries on these two platforms that often use
these large page sizes.
This probably needs some tweaking, we'll see what CI says. This isn't going to fix everything, we need to pass the same flags within BinaryBuilder, then rebuild the world so that Julia can work on AArch64.