Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix findfirst with decreasing step range #33809

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Fix findfirst with decreasing step range #33809

merged 2 commits into from
Nov 13, 2019

Conversation

laborg
Copy link
Contributor

@laborg laborg commented Nov 11, 2019 •
edited
Loading

Fixes #33808
findfirst assumed increasing step size for StepRange.

raminammour
raminammour reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@raminammour raminammour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add:

isempty(r) && return nothing

Fixes things like:

julia> findfirst(==(2),1:-1:2)
0

@mbauman
Copy link
Sponsor Member

mbauman commented Nov 12, 2019

Man, what's going on with CI? 6 ❌s, all different and seemingly unrelated!? Let's try that again.

@mbauman mbauman closed this Nov 12, 2019
@mbauman mbauman reopened this Nov 12, 2019
@JeffBezanson JeffBezanson merged commit 8333297 into JuliaLang:master Nov 13, 2019
JeffBezanson pushed a commit that referenced this pull request Nov 13, 2019
@laborg @JeffBezanson
Fix findfirst with decreasing step range (#33809)
78b7402 
Fixes #33808
(cherry picked from commit 8333297)
@KristofferC KristofferC mentioned this pull request Nov 15, 2019
Merged
19 tasks
@KristofferC KristofferC mentioned this pull request Dec 3, 2019
Closed
56 tasks
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@laborg @KristofferC
Fix findfirst with decreasing step range (#33809)
0662e9c 
Fixes #33808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbauman mbauman mbauman approved these changes

@rfourquet rfourquet rfourquet approved these changes

@raminammour raminammour raminammour approved these changes

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buggy findfirst(p::Union{Fix2{typeof(==),T}, Fix2{typeof(isequal),T}}, r::StepRange{T,S}) where {T, S}?
6 participants
@laborg @mbauman @rfourquet @raminammour @dkarrasch @JeffBezanson