REPL: fix yank-twice activates region #33814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
REPL
Yanking twice was fooling `setmark` into believing that `^Space`, the keybinding for `setmark`, had been pressed twice, leading to activating the region. So let's make `setmark` behave as a "command" (and activate the region) only when called directly by the user, otherwise treat it as a low-level function.
rfourquet
force-pushed
the
rf/repl/fix-yank-activate
branch
from
82f5f1d
to
da54646
Compare
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Yanking twice was fooling `setmark` into believing that `^Space`, the keybinding for `setmark`, had been pressed twice, leading to activating the region. So let's make `setmark` behave as a "command" (and activate the region) only when called directly by the user, otherwise treat it as a low-level function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yanking twice was fooling
setmarkinto believingthat
^Space, the keybinding forsetmark, hadbeen pressed twice, leading to activating the region.
So let's make
setmarkbehave as a "command" (andactivate the region) only when called directly by
the user, otherwise treat it as a low-level function.