codegen: optimize returning an argument #33829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a good idea in general, but can we get a codegen test to make sure this doesn't regress? |
It's not unusual to have code that simply returns an argument. When used in generic code though, that currently might involve copying the value to a new box. We sometimes define functions like `identity(nospecialize x) = x` to work around that, (which is preferable anyways for other reasons), but it's better for codegen to also just be aware of this pattern.
vtjnash
force-pushed
the
jn/optimize-identity
branch
from
3d74966
to
c06292f
Compare
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
It's not unusual to have code that simply returns an argument. When used in generic code though, that currently might involve copying the value to a new box. We sometimes define functions like `identity(nospecialize x) = x` to work around that, (which is preferable anyways for other reasons), but it's better for codegen to also just be aware of this pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not unusual to have code that simply returns an argument. When
used in generic code though, that currently might involve copying the
value to a new box. We sometimes define functions like
identity(nospecialize x) = xto work around that, (which is preferableanyways for other reasons), but it's better for codegen to also just be
aware of this pattern.