fix #33768, inference of _apply with strange argument list lengths
#33832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
bugfix
vtjnash
reviewed
Nov 13, 2019
| return abstract_apply(nothing, argtypes[2], argtypes[3:end], vtypes, sv, max_methods) | ||
| ft = argtype_by_index(argtypes, 2) | ||
| ft === Bottom && return Bottom | ||
| return abstract_apply(nothing, ft, argtypes[3:end], vtypes, sv, max_methods) |
There was a problem hiding this comment.
If index 2 can be bad, that seems to imply that 3:end would be bad too (vararg case)?
There was a problem hiding this comment.
It's ok, it just gives an empty array.
There was a problem hiding this comment.
right—that seems it'd be bad if argtypes = [f, Vararg{t}], since the slice should give [Vararg{t}]
There was a problem hiding this comment.
I think that would probably be fine actually. I think the problematic part is argtypes = [Vararg{t}] since then argtypes[3:end] is [], but clearly there are args there.
JeffBezanson
force-pushed
the
jb/fix33768
branch
from
48f0c20
to
f9fc3e1
Compare
vtjnash
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #33768