Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #32980 #33983

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Fix #32980 #33983

merged 1 commit into from
Dec 12, 2019

Conversation

cmcaine
Copy link
Contributor

@cmcaine cmcaine commented Nov 29, 2019

This was introduced in: e2821f594c5e9b2ec0fa1603f4e90628d2e40cd7

Package managers track which package owns a file, and if the
icon-theme.cache is owned by Julia, the package manager will get
confused when that file already exists on the system or when another
process overwrites it.

It's the DE's job to update that cache.

Fixes #32980.

This was introduced in: e2821f594c5e9b2ec0fa1603f4e90628d2e40cd7

Package managers track which package owns a file, and if the
icon-theme.cache is owned by Julia, the package manager will get
confused when that file already exists on the system or when another
process overwrites it.

It's the DE's job to update that cache.
@cmcaine
Copy link
Contributor Author

cmcaine commented Dec 12, 2019

Requesting review.

@fredrikekre fredrikekre added the building Build system, or building Julia or its dependencies label Dec 12, 2019
@staticfloat
Copy link
Sponsor Member

We need @nalimilan to take a look at this, as he was the one that introduced the icon cache at all. I'm not sure whether we should or should not be shipping this file.

@StefanKarpinski StefanKarpinski merged commit 8bef999 into JuliaLang:master Dec 12, 2019
KristofferC pushed a commit that referenced this pull request Dec 17, 2019
This was introduced in: e2821f594c5e9b2ec0fa1603f4e90628d2e40cd7

Package managers track which package owns a file, and if the
icon-theme.cache is owned by Julia, the package manager will get
confused when that file already exists on the system or when another
process overwrites it.

It's the DE's job to update that cache.

(cherry picked from commit 8bef999)
@KristofferC KristofferC mentioned this pull request Dec 17, 2019
18 tasks
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
This was introduced in: e2821f594c5e9b2ec0fa1603f4e90628d2e40cd7

Package managers track which package owns a file, and if the
icon-theme.cache is owned by Julia, the package manager will get
confused when that file already exists on the system or when another
process overwrites it.

It's the DE's job to update that cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stray icon-theme.cache file in the 1.2 Linux release
5 participants