Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a compatibility fallback for divrem and fldmod #34284

Merged
merged 1 commit into from
Jan 7, 2020
Merged

add a compatibility fallback for divrem and fldmod #34284

merged 1 commit into from
Jan 7, 2020

Conversation

JeffBezanson
Copy link
Sponsor Member

@JeffBezanson JeffBezanson commented Jan 6, 2020 •
edited
Loading

Fixes test failures in AbstractNumbers.jl and CurrenciesBase/FixedDecimals.

@JeffBezanson JeffBezanson mentioned this pull request Jan 6, 2020
Merged
28 tasks
@JeffBezanson
restrict div fallback to Real
10d10d4 
add more-compatible fallback for `divrem`
@JeffBezanson
Copy link
Sponsor Member Author

Ok, that didn't work since some non-number types like Periods also implement this. I guess we'll have to sacrifice applicable? (AbstractNumbers was using it to determine which functions to test on which types.)

@JeffBezanson JeffBezanson changed the title restrict div fallback to Real add a compatibility fallback for fldmod Jan 6, 2020
@JeffBezanson JeffBezanson changed the title add a compatibility fallback for fldmod add a compatibility fallback for divrem and fldmod Jan 6, 2020
@JeffBezanson JeffBezanson merged commit 8f53987 into master Jan 7, 2020
@JeffBezanson JeffBezanson deleted the jb/divfallback branch January 7, 2020 20:52
KristofferC pushed a commit that referenced this pull request Jan 8, 2020
@JeffBezanson @KristofferC
restrict div fallback to Real (#34284)
8eee8d5 
add more-compatible fallback for `divrem`

(cherry picked from commit 8f53987)
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@JeffBezanson @KristofferC
restrict div fallback to Real (#34284)
6fc5775 
add more-compatible fallback for `divrem`
BioTurboNick pushed a commit to BioTurboNick/julia that referenced this pull request Apr 13, 2020
@JeffBezanson @BioTurboNick
restrict div fallback to Real (JuliaLang#34284)
7b1f512 
add more-compatible fallback for `divrem`

(cherry picked from commit 8f53987)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @KristofferC