Add clamp(x, T) #34426
Merged
Add clamp(x, T) #34426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is #22235, but with the reversed argument order. ``` julia> clamp( 260, UInt8 ) 0xff ``` Co-authored-by: "arghhhh <[email protected]>"
|
A difficult argument order situation, but I think I agree. My explanation would be that functions primarily about converting between types (convert, trunc, ...) put the type first, but other functions where a type stands in for numbers, ranges, etc. leave the argument in its natural position (clamp, %, ...). |
|
Yes, I think the genericness argument wins here. E.g. if we wanted to clamp to some interval |
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
This is #22235, but with the reversed argument order. ``` julia> clamp( 260, UInt8 ) 0xff ``` Co-authored-by: "arghhhh <[email protected]>"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #22235, but with the reversed argument order.
Co-authored-by: "arghhhh [email protected]"