add <: to add-dots #35085

ssikdar1 · 2020-03-12T03:59:50Z

Fixes #34839 .
Add <: to add-dots.

Testing

Not sure if there's somewhere to add a test?
But testing in the REPL:

julia> [Int, Float64, String, Bool] .<: Union{Int, String}
4-element BitArray{1}:
 1
 0
 1
 0

src/julia-parser.scm

stevengj · 2020-03-12T14:56:53Z

Probably add a test to test/broadcast.jl or test/parse.jl?

mbauman · 2020-03-12T16:00:41Z

What should @. do? It currently leaves <: alone.

julia> @macroexpand @. [Int, Number] <: Real
:([Int, Number] <: Real)

stevengj · 2020-03-12T21:02:58Z

@mbauman, the PR will need a case for head === :(<:) here.

ssikdar1 · 2020-03-13T01:10:01Z

@stevengj

Tried to add a test case in 2e2c6bf.
And tried to add a conditional case for __dot__ in c364df6. ( not sure if this is correct ).

ssikdar1 · 2020-03-15T05:04:58Z

Tried to add .>: in 2fca8fa

There's seems to be an exception that being printed to stderr somewhere that doesn't actually affect the outcome of executing .>:.

For example:

$ cat foo.jl 
@show [Int, Float64, String, Bool] .>: Union{Int, String}

Redirecting stderr to /dev/null everything is okay.

$ ./julia foo.jl 2>/dev/null 
[Int, Float64, String, Bool] .>: Union{Int, String} = Bool[0, 0, 0, 0]

However without it:

$ ./julia foo.jl
Internal error: encountered unexpected error in runtime:
MethodError(f=typeof(Core.Compiler.length)(), args=(nothing,), world=0x0000000000000f46)
jl_method_error_bare at /Users/ssikdar1/julia/src/gf.c:1722
jl_method_error at /Users/ssikdar1/julia/src/gf.c:1740
jl_lookup_generic_ at /Users/ssikdar1/julia/src/gf.c:2311
jl_apply_generic at /Users/ssikdar1/julia/src/gf.c:2332
abstract_call_known at ./compiler/abstractinterpretation.jl:854
abstract_call at ./compiler/abstractinterpretation.jl:905
return_type_tfunc at ./compiler/tfuncs.jl:1491
abstract_call_known at ./compiler/abstractinterpretation.jl:830
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_call at ./compiler/abstractinterpretation.jl:890
abstract_eval at ./compiler/abstractinterpretation.jl:984
typeinf_local at ./compiler/abstractinterpretation.jl:1238
typeinf_nocycle at ./compiler/abstractinterpretation.jl:1294
typeinf at ./compiler/typeinfer.jl:12
typeinf_edge at ./compiler/typeinfer.jl:484
abstract_call_method at ./compiler/abstractinterpretation.jl:414
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:111
abstract_call_known at ./compiler/abstractinterpretation.jl:883
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_call at ./compiler/abstractinterpretation.jl:890
abstract_eval at ./compiler/abstractinterpretation.jl:984
typeinf_local at ./compiler/abstractinterpretation.jl:1223
typeinf_nocycle at ./compiler/abstractinterpretation.jl:1294
typeinf at ./compiler/typeinfer.jl:12
typeinf_edge at ./compiler/typeinfer.jl:484
abstract_call_method at ./compiler/abstractinterpretation.jl:414
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:111
abstract_call_known at ./compiler/abstractinterpretation.jl:883
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_call at ./compiler/abstractinterpretation.jl:890
abstract_eval at ./compiler/abstractinterpretation.jl:984
typeinf_local at ./compiler/abstractinterpretation.jl:1238
typeinf_nocycle at ./compiler/abstractinterpretation.jl:1294
typeinf at ./compiler/typeinfer.jl:12
typeinf_ext at ./compiler/typeinfer.jl:570
typeinf_ext at ./compiler/typeinfer.jl:601
jfptr_typeinf_ext_22237 at /Users/ssikdar1/julia/usr/lib/julia/sys.dylib (unknown line)
jl_apply at /Users/ssikdar1/julia/src/./julia.h:1696 [inlined]
jl_type_infer at /Users/ssikdar1/julia/src/gf.c:215
jl_generate_fptr at /Users/ssikdar1/julia/src/jitlayers.cpp:232
jl_compile_method_internal at /Users/ssikdar1/julia/src/gf.c:1902
_jl_invoke at /Users/ssikdar1/julia/src/gf.c:2162 [inlined]
jl_apply_generic at /Users/ssikdar1/julia/src/gf.c:2336
jl_apply at /Users/ssikdar1/julia/src/./julia.h:1696 [inlined]
do_call at /Users/ssikdar1/julia/src/interpreter.c:369
eval_stmt_value at /Users/ssikdar1/julia/src/interpreter.c:409 [inlined]
eval_body at /Users/ssikdar1/julia/src/interpreter.c:807
jl_interpret_toplevel_thunk at /Users/ssikdar1/julia/src/interpreter.c:915
top-level scope at show.jl:613
jl_toplevel_eval_flex at /Users/ssikdar1/julia/src/toplevel.c:813
jl_parse_eval_all at /Users/ssikdar1/julia/src/ast.c:907
jl_load_rewrite at /Users/ssikdar1/julia/src/toplevel.c:871 [inlined]
jl_load at /Users/ssikdar1/julia/src/toplevel.c:876
include at ./Base.jl:380
include at ./Base.jl:368
exec_options at ./client.jl:288
_start at ./client.jl:490
jfptr__start_54862 at /Users/ssikdar1/julia/usr/lib/julia/sys.dylib (unknown line)
true_main at /Users/ssikdar1/julia/./julia (unknown line)
main at /Users/ssikdar1/julia/./julia (unknown line)
Internal error: encountered unexpected error in runtime:
MethodError(f=typeof(Core.Compiler.length)(), args=(nothing,), world=0x0000000000000f46)
jl_method_error_bare at /Users/ssikdar1/julia/src/gf.c:1722
jl_method_error at /Users/ssikdar1/julia/src/gf.c:1740
jl_lookup_generic_ at /Users/ssikdar1/julia/src/gf.c:2311
jl_apply_generic at /Users/ssikdar1/julia/src/gf.c:2332
abstract_call_known at ./compiler/abstractinterpretation.jl:854
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_apply at ./compiler/abstractinterpretation.jl:614
abstract_call_known at ./compiler/abstractinterpretation.jl:683
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_call at ./compiler/abstractinterpretation.jl:890
abstract_eval at ./compiler/abstractinterpretation.jl:984
typeinf_local at ./compiler/abstractinterpretation.jl:1238
typeinf_nocycle at ./compiler/abstractinterpretation.jl:1294
typeinf at ./compiler/typeinfer.jl:12
typeinf_edge at ./compiler/typeinfer.jl:484
abstract_call_method at ./compiler/abstractinterpretation.jl:414
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:111
abstract_call_known at ./compiler/abstractinterpretation.jl:883
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_apply at ./compiler/abstractinterpretation.jl:614
abstract_call_known at ./compiler/abstractinterpretation.jl:683
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_call at ./compiler/abstractinterpretation.jl:890
abstract_eval at ./compiler/abstractinterpretation.jl:984
typeinf_local at ./compiler/abstractinterpretation.jl:1238
typeinf_nocycle at ./compiler/abstractinterpretation.jl:1294
typeinf at ./compiler/typeinfer.jl:12
typeinf_edge at ./compiler/typeinfer.jl:484
abstract_call_method at ./compiler/abstractinterpretation.jl:414
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:111
abstract_call_known at ./compiler/abstractinterpretation.jl:883
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_call at ./compiler/abstractinterpretation.jl:890
abstract_eval at ./compiler/abstractinterpretation.jl:984
typeinf_local at ./compiler/abstractinterpretation.jl:1223
typeinf_nocycle at ./compiler/abstractinterpretation.jl:1294
typeinf at ./compiler/typeinfer.jl:12
typeinf_edge at ./compiler/typeinfer.jl:484
abstract_call_method at ./compiler/abstractinterpretation.jl:414
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:111
abstract_call_known at ./compiler/abstractinterpretation.jl:883
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_call at ./compiler/abstractinterpretation.jl:890
abstract_eval at ./compiler/abstractinterpretation.jl:984
typeinf_local at ./compiler/abstractinterpretation.jl:1238
typeinf_nocycle at ./compiler/abstractinterpretation.jl:1294
typeinf at ./compiler/typeinfer.jl:12
typeinf_edge at ./compiler/typeinfer.jl:484
invoke_tfunc at ./compiler/tfuncs.jl:1170
builtin_tfunction at ./compiler/tfuncs.jl:1360
builtin_tfunction at ./compiler/tfuncs.jl:1309 [inlined]
abstract_call_known at ./compiler/abstractinterpretation.jl:699
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_call at ./compiler/abstractinterpretation.jl:890
abstract_eval at ./compiler/abstractinterpretation.jl:984
typeinf_local at ./compiler/abstractinterpretation.jl:1238
typeinf_nocycle at ./compiler/abstractinterpretation.jl:1294
typeinf at ./compiler/typeinfer.jl:12
typeinf_edge at ./compiler/typeinfer.jl:484
abstract_call_method at ./compiler/abstractinterpretation.jl:414
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:111
abstract_call_known at ./compiler/abstractinterpretation.jl:883
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_call at ./compiler/abstractinterpretation.jl:890
abstract_eval at ./compiler/abstractinterpretation.jl:984
typeinf_local at ./compiler/abstractinterpretation.jl:1238
typeinf_nocycle at ./compiler/abstractinterpretation.jl:1294
typeinf at ./compiler/typeinfer.jl:12
typeinf_ext at ./compiler/typeinfer.jl:570
typeinf_ext at ./compiler/typeinfer.jl:601
jfptr_typeinf_ext_22237 at /Users/ssikdar1/julia/usr/lib/julia/sys.dylib (unknown line)
jl_apply at /Users/ssikdar1/julia/src/./julia.h:1696 [inlined]
jl_type_infer at /Users/ssikdar1/julia/src/gf.c:215
jl_generate_fptr at /Users/ssikdar1/julia/src/jitlayers.cpp:232
jl_compile_method_internal at /Users/ssikdar1/julia/src/gf.c:1902
_jl_invoke at /Users/ssikdar1/julia/src/gf.c:2162 [inlined]
jl_apply_generic at /Users/ssikdar1/julia/src/gf.c:2336
copy at ./broadcast.jl:840
materialize at ./broadcast.jl:820
jl_apply at /Users/ssikdar1/julia/src/./julia.h:1696 [inlined]
do_call at /Users/ssikdar1/julia/src/interpreter.c:369
eval_stmt_value at /Users/ssikdar1/julia/src/interpreter.c:409 [inlined]
eval_body at /Users/ssikdar1/julia/src/interpreter.c:807
jl_interpret_toplevel_thunk at /Users/ssikdar1/julia/src/interpreter.c:915
top-level scope at show.jl:613
jl_toplevel_eval_flex at /Users/ssikdar1/julia/src/toplevel.c:813
jl_parse_eval_all at /Users/ssikdar1/julia/src/ast.c:907
jl_load_rewrite at /Users/ssikdar1/julia/src/toplevel.c:871 [inlined]
jl_load at /Users/ssikdar1/julia/src/toplevel.c:876
include at ./Base.jl:380
include at ./Base.jl:368
exec_options at ./client.jl:288
_start at ./client.jl:490
jfptr__start_54862 at /Users/ssikdar1/julia/usr/lib/julia/sys.dylib (unknown line)
true_main at /Users/ssikdar1/julia/./julia (unknown line)
main at /Users/ssikdar1/julia/./julia (unknown line)
Internal error: encountered unexpected error in runtime:
MethodError(f=typeof(Core.Compiler.length)(), args=(nothing,), world=0x0000000000000f46)
jl_method_error_bare at /Users/ssikdar1/julia/src/gf.c:1722
jl_method_error at /Users/ssikdar1/julia/src/gf.c:1740
jl_lookup_generic_ at /Users/ssikdar1/julia/src/gf.c:2311
jl_apply_generic at /Users/ssikdar1/julia/src/gf.c:2332
abstract_call_known at ./compiler/abstractinterpretation.jl:854
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_apply at ./compiler/abstractinterpretation.jl:614
abstract_call_known at ./compiler/abstractinterpretation.jl:683
abstract_call at ./compiler/abstractinterpretation.jl:905
abstract_call at ./compiler/abstractinterpretation.jl:890
abstract_eval at ./compiler/abstractinterpretation.jl:984
typeinf_local at ./compiler/abstractinterpretation.jl:1238
typeinf_nocycle at ./compiler/abstractinterpretation.jl:1294
typeinf at ./compiler/typeinfer.jl:12
typeinf_ext at ./compiler/typeinfer.jl:570
typeinf_ext at ./compiler/typeinfer.jl:601
jfptr_typeinf_ext_22237 at /Users/ssikdar1/julia/usr/lib/julia/sys.dylib (unknown line)
jl_apply at /Users/ssikdar1/julia/src/./julia.h:1696 [inlined]
jl_type_infer at /Users/ssikdar1/julia/src/gf.c:215
jl_generate_fptr at /Users/ssikdar1/julia/src/jitlayers.cpp:232
jl_compile_method_internal at /Users/ssikdar1/julia/src/gf.c:1902
_jl_invoke at /Users/ssikdar1/julia/src/gf.c:2162 [inlined]
jl_apply_generic at /Users/ssikdar1/julia/src/gf.c:2336
jl_apply at /Users/ssikdar1/julia/src/./julia.h:1696 [inlined]
do_apply at /Users/ssikdar1/julia/src/builtins.c:643
_broadcast_getindex at ./broadcast.jl:619
getindex at ./broadcast.jl:564
macro expansion at ./broadcast.jl:910 [inlined]
macro expansion at ./simdloop.jl:77 [inlined]
copyto! at ./broadcast.jl:909
_jl_invoke at /Users/ssikdar1/julia/src/gf.c:2169 [inlined]
jl_gf_invoke_by_method at /Users/ssikdar1/julia/src/gf.c:2420 [inlined]
jl_gf_invoke at /Users/ssikdar1/julia/src/gf.c:2385
jl_f_invoke at /Users/ssikdar1/julia/src/builtins.c:1007
copyto! at ./broadcast.jl:920
copyto! at ./broadcast.jl:864
copy at ./broadcast.jl:840
materialize at ./broadcast.jl:820
jl_apply at /Users/ssikdar1/julia/src/./julia.h:1696 [inlined]
do_call at /Users/ssikdar1/julia/src/interpreter.c:369
eval_stmt_value at /Users/ssikdar1/julia/src/interpreter.c:409 [inlined]
eval_body at /Users/ssikdar1/julia/src/interpreter.c:807
jl_interpret_toplevel_thunk at /Users/ssikdar1/julia/src/interpreter.c:915
top-level scope at show.jl:613
jl_toplevel_eval_flex at /Users/ssikdar1/julia/src/toplevel.c:813
jl_parse_eval_all at /Users/ssikdar1/julia/src/ast.c:907
jl_load_rewrite at /Users/ssikdar1/julia/src/toplevel.c:871 [inlined]
jl_load at /Users/ssikdar1/julia/src/toplevel.c:876
include at ./Base.jl:380
include at ./Base.jl:368
exec_options at ./client.jl:288
_start at ./client.jl:490
jfptr__start_54862 at /Users/ssikdar1/julia/usr/lib/julia/sys.dylib (unknown line)
true_main at /Users/ssikdar1/julia/./julia (unknown line)
main at /Users/ssikdar1/julia/./julia (unknown line)
[Int, Float64, String, Bool] .>: Union{Int, String} = Bool[0, 0, 0, 0]

JeffBezanson · 2020-03-16T21:04:11Z

A non-fatal internal error is happening and getting printed; execution continues. I'll look into it.

ssikdar1 · 2020-03-19T04:33:39Z

With @JeffBezanson #35136 , .>: looks to be working!

$ cat foo.jl 
@show [Int, Float64, String, Bool] .>: Union{Int, String}

$ ./julia foo.jl 
[Int, Float64, String, Bool] .>: Union{Int, String} = Bool[0, 0, 0, 0]

base/broadcast.jl

test/parse.jl

base/broadcast.jl

NEWS.md

test/broadcast.jl

add <: to add-dots

813de45

stevengj reviewed Mar 12, 2020

View reviewed changes

src/julia-parser.scm Outdated Show resolved Hide resolved

stevengj added the parser Language parsing and surface syntax label Mar 12, 2020

ararslan added needs news A NEWS entry is required for this change needs tests Unit tests are required for this change labels Mar 12, 2020

ssikdar1 added 2 commits March 12, 2020 20:08

add <: case to __dot__

c364df6

add test for .<:

2e2c6bf

ssikdar1 added 2 commits March 12, 2020 22:05

fix test

a340e97

add .>: as well

2fca8fa

JeffBezanson mentioned this pull request Mar 16, 2020

fix bug in t-function for >: #35136

Merged

Merge remote-tracking branch 'upstream/master' into dots

5d99893

stevengj reviewed Mar 22, 2020

View reviewed changes

base/broadcast.jl Outdated Show resolved Hide resolved

stevengj reviewed Mar 22, 2020

View reviewed changes

test/parse.jl Show resolved Hide resolved

ssikdar1 added 5 commits March 22, 2020 10:48

add @. <: test

a3e3ec4

update __dot__ expr to call expr

acbd660

Merge remote-tracking branch 'upstream/master' into dots

bc59aa9

add NEWS item for PR

1d96e71

Merge branch 'master' into dots

6cb0a42

stevengj reviewed Mar 28, 2020

View reviewed changes

base/broadcast.jl Outdated Show resolved Hide resolved

stevengj reviewed Mar 28, 2020

View reviewed changes

NEWS.md Outdated Show resolved Hide resolved

add in code review comments

243f65e

stevengj approved these changes Mar 30, 2020

View reviewed changes

Merge branch 'master' into dots

959925c

Merge branch 'master' into dots

7c0a629

stevengj added triage This should be discussed on a triage call and removed needs news A NEWS entry is required for this change needs tests Unit tests are required for this change labels May 6, 2020

JeffBezanson reviewed May 6, 2020

View reviewed changes

NEWS.md Outdated Show resolved Hide resolved

JeffBezanson reviewed May 6, 2020

View reviewed changes

NEWS.md Outdated Show resolved Hide resolved

JeffBezanson reviewed May 6, 2020

View reviewed changes

NEWS.md Outdated Show resolved Hide resolved

JeffBezanson reviewed May 6, 2020

View reviewed changes

test/broadcast.jl Outdated Show resolved Hide resolved

fix format NEWS

eb6df88

JeffBezanson merged commit 99dbd2d into JuliaLang:master May 6, 2020

ssikdar1 deleted the dots branch May 6, 2020 15:16

JeffBezanson removed the triage This should be discussed on a triage call label May 28, 2020

JeffBezanson mentioned this pull request Jul 18, 2020

fix precedence of dotted <: and >: #36725

Merged

JeffBezanson mentioned this pull request Aug 31, 2020

Vectorized subtype comparison #34839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add <: to add-dots #35085

add <: to add-dots #35085

ssikdar1 commented Mar 12, 2020 •

edited

Loading

stevengj commented Mar 12, 2020

mbauman commented Mar 12, 2020

stevengj commented Mar 12, 2020

ssikdar1 commented Mar 13, 2020 •

edited

Loading

ssikdar1 commented Mar 15, 2020

JeffBezanson commented Mar 16, 2020

ssikdar1 commented Mar 19, 2020 •

edited

Loading

add <: to add-dots #35085

add <: to add-dots #35085

Conversation

ssikdar1 commented Mar 12, 2020 • edited Loading

Testing

stevengj commented Mar 12, 2020

mbauman commented Mar 12, 2020

stevengj commented Mar 12, 2020

ssikdar1 commented Mar 13, 2020 • edited Loading

ssikdar1 commented Mar 15, 2020

JeffBezanson commented Mar 16, 2020

ssikdar1 commented Mar 19, 2020 • edited Loading

ssikdar1 commented Mar 12, 2020 •

edited

Loading

ssikdar1 commented Mar 13, 2020 •

edited

Loading

ssikdar1 commented Mar 19, 2020 •

edited

Loading