Bump libgit2 to 1.0 #35233
Bump libgit2 to 1.0 #35233
Conversation
Until we can build 1.0.0 (#35233).
Until we can build 1.0.0 (#35233).
Until we can build 1.0.0 (#35233).
Until we can build 1.0.0 (#35233).
|
I've updated the PR now that LibGit2 1.0.0 has been added to Yggdrasil. I've also added a commit to remove any occurrence of curl, since AFAICT the only user of it was libgit2, which now uses its own internal library by default. This could break packages that relied on libcurl being available (if any), but they should use BinaryProvider instead. |
Until we can build 1.0.0 (JuliaLang#35233).
|
We probably don't want to remove libcurl here, since we're about to add a new client of libcurl via @StefanKarpinski's new curl-based downloader. Cool that libgit2 dropped dependence on it though! |
|
OK, I've reverted the removal of curl. Good to go? |
There was a problem hiding this comment.
I think you need to add the necessary hashes to julia/deps/checksums/, and remove the old ones.
It also looks like https://github.com/JuliaLang/julia/blob/master/deps/patches/libgit2-case-sensitive.patch is no longer necessary?
|
Ah right. Done. (It looks like the checksums for the tarball were missing for the currently used release, but nobody tests this path now...) |
Needs JuliaPackaging/Yggdrasil#638 so that BinaryBuilder can provide the new version. We also need to update the build flags to sync with Yggdrasil if we decide to keep using LibCURL there.
This drops support for previous versions, but we could keep it if needed by adding new branches.