fix a bug in circular type detection #35275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, right. This was introduced in #34223. I'm still in general skeptical (more so now that I see the mistake there that I missed on previous review) of this half-ways approach to switching this function over from the conservative approximation first implemented, to the more aggressive form (of actually checking the field types) that it could do. CI failure is just a repr mistake with defining this test: |
JeffBezanson
force-pushed
the
jb/circulartypefix
branch
from
7b2c2bd
to
7d16fe9
Compare
JeffBezanson
force-pushed
the
jb/circulartypefix
branch
from
7d16fe9
to
edcabdf
Compare
oxinabox
pushed a commit
to oxinabox/julia
that referenced
this pull request
Apr 8, 2020
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
staticfloat
pushed a commit
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one of the issues in #34126