Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UnicodeData checksum #35356

Merged
merged 1 commit into from
Apr 4, 2020
Merged

Update UnicodeData checksum #35356

merged 1 commit into from
Apr 4, 2020

Conversation

staticfloat
Copy link
Member

Upstream has apparently modified this file as of March 30th 2020, which
is annoying as it has broken all older builds of Julia attempting to
download and check this file.

Upstream has apparently modified this file as of March 30th 2020, which
is annoying as it has broken all older builds of Julia attempting to
download and check this file.
@StefanKarpinski
Copy link
Member

Wow, that's extremely uncool of them. Perhaps we should host our own copy of this file and update if upstream changes?

Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help if we gave this a new name also on our side?

@staticfloat staticfloat closed this Apr 3, 2020
@staticfloat staticfloat reopened this Apr 3, 2020
@staticfloat staticfloat merged commit c980519 into master Apr 4, 2020
@staticfloat staticfloat deleted the sf/fix_unicode_checksum branch April 4, 2020 00:18
KristofferC pushed a commit that referenced this pull request Apr 4, 2020
Upstream has apparently modified this file as of March 30th 2020, which
is annoying as it has broken all older builds of Julia attempting to
download and check this file.

(cherry picked from commit c980519)
@KristofferC KristofferC mentioned this pull request Apr 4, 2020
27 tasks
@staticfloat
Copy link
Member Author

Would it help if we gave this a new name also on our side?

Yes, it turns out that we were storing this as an unversioned filename, so different branches conflicted.

oxinabox pushed a commit to oxinabox/julia that referenced this pull request Apr 8, 2020
Upstream has apparently modified this file as of March 30th 2020, which
is annoying as it has broken all older builds of Julia attempting to
download and check this file.
ravibitsgoa pushed a commit to ravibitsgoa/julia that referenced this pull request Apr 9, 2020
Upstream has apparently modified this file as of March 30th 2020, which
is annoying as it has broken all older builds of Julia attempting to
download and check this file.
KristofferC pushed a commit that referenced this pull request Apr 15, 2020
Upstream has apparently modified this file as of March 30th 2020, which
is annoying as it has broken all older builds of Julia attempting to
download and check this file.

(cherry picked from commit c980519)
@KristofferC KristofferC mentioned this pull request Apr 15, 2020
56 tasks
ztultrebor pushed a commit to ztultrebor/julia that referenced this pull request Apr 17, 2020
Upstream has apparently modified this file as of March 30th 2020, which
is annoying as it has broken all older builds of Julia attempting to
download and check this file.
staticfloat added a commit that referenced this pull request Apr 21, 2020
Upstream has apparently modified this file as of March 30th 2020, which
is annoying as it has broken all older builds of Julia attempting to
download and check this file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants