Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename pop!(vector, idx, [default]) to popat! #36070

Merged
merged 2 commits into from
Jun 2, 2020
Merged

rename pop!(vector, idx, [default]) to popat! #36070

merged 2 commits into from
Jun 2, 2020

Conversation

rfourquet
Copy link
Member

Cf. discussion at #35513.
Compared to splice!, popat! admits a default, and can be faster (e.g. 40% faster).

When backported, I will make a PR to the 1.5 branch to update the NEWS.

@rfourquet rfourquet added this to the 1.5 milestone May 30, 2020
@KristofferC KristofferC merged commit 0164101 into master Jun 2, 2020
@KristofferC KristofferC deleted the rf/popat branch June 2, 2020 14:28
KristofferC pushed a commit that referenced this pull request Jun 4, 2020
* rename pop!(vector, idx, [default]) to popat!

* popat! : explain what `default` is

(cherry picked from commit 0164101)
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
* rename pop!(vector, idx, [default]) to popat!

* popat! : explain what `default` is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants