fix #36116, diff(::AbstractRange) returns an Array #36117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
reviewed
Jun 2, 2020
mbauman
commented
Jun 2, 2020
mbauman
commented
Jun 2, 2020
mbauman
commented
Jun 2, 2020
26 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jun 4, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
…g#36117) * fix JuliaLang#36116, diff(::AbstractRange) returns an Array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's oh so tempting to simply define
diff(r::AbstractRange) = fill(step(r), length(r)-1), (or even aFill), but this preserves the behavior that we had on 1.4 and before — and is arguably what folks want. It's not the repeated theoretical step, but the realized sequential differences of the generated elements.