Precompile a get! instance used by Requires
#37256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In conjunction with xref JuliaPackaging/Requires.jl#89, this shaves about 100ms off the first usage of Requires.
KristofferC
approved these changes
Aug 28, 2020
oscardssmith
pushed a commit
to oscardssmith/julia
that referenced
this pull request
Aug 28, 2020
In conjunction with xref JuliaPackaging/Requires.jl#89, this shaves about 100ms off the first usage of Requires.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
In conjunction with xref JuliaPackaging/Requires.jl#89, this shaves about 100ms off the first usage of Requires.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with xref JuliaPackaging/Requires.jl#89, this shaves about 100ms off the first usage of Requires. Aside from the 60ms it takes to load Requires, this pretty much eliminates the disincentives for using it (the remaining compilation time is basically negligible).