Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Dict to be ordered by default #38145

Closed
wants to merge 7 commits into from
Closed

Change Dict to be ordered by default #38145

wants to merge 7 commits into from

Commits on Oct 22, 2020

  1. Change Dict to be ordered by default, changing older to unexported Ud… 

    …ict.
    Páll Haraldsson authored and Páll Haraldsson committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    9addde2 View commit details
    Browse the repository at this point in the history

  2. Fixes docs? And revert making WeakKeyiDict ordered.

    Páll Haraldsson authored and Páll Haraldsson committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    cbd8120 View commit details
    Browse the repository at this point in the history

  3. Silence doc error?

    Páll Haraldsson authored and Páll Haraldsson committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    abc8309 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Fix the name you get back.

    Páll Haraldsson authored and Páll Haraldsson committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    e641421 View commit details
    Browse the repository at this point in the history

  2. One more doc fix.

    Páll Haraldsson authored and Páll Haraldsson committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a6c69d7 View commit details
    Browse the repository at this point in the history

  3. Change WeakKeyDict to use the new Dict (it was failing with old) 

    to try to silence test error. Change Set to, so no unordered used.
    Páll Haraldsson authored and Páll Haraldsson committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    755a156 View commit details
    Browse the repository at this point in the history

  4. Change Set back to unordered, i.e. UDict, as it invasively uses 

    skip_deleted_floor! from the old Dict (now UDict), that no ordered dict
has and ht_keyindex2! (OrderedDict only has ht_keyindex2;
swissdict.jl does, but it's not ordered).
    Páll Haraldsson authored and Páll Haraldsson committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    760fe11 View commit details
    Browse the repository at this point in the history