Fix invalidation in show_unquoted #38265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this assertion `arg1` is inferred as `Any`, and the method gets invalidated when loading CategoricalArrays. Not sure why the compiler isn't able to detect the type automatically given the `isa` checks in the `if`.
timholy
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
You nailed it. Very impressive as always, @nalimilan!
Inference doesn't seem to always propagate type information across logical operators, but I don't have an explanation why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this assertion
arg1is inferred asAny, and the method gets invalidated when loading CategoricalArrays (JuliaData/CategoricalArrays.jl#177 (comment)). Not sure why the compiler isn't able to detect the type automatically given theisachecks in theif.