Arg. to avoid escaping backslahes (escape_string) #38597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an argument to `escape_string` to assume that all backslashes (`\\`) are already escaped. Hence, `\\cdot` becomes `\\cdot` instead of `\\\\cdot`. The default value to this argument is `false`. Hence, this does not break any existing code since `escape_string` behaves exactly the same as before if no additional option is passed. Closes #34042
Keno
reviewed
Nov 29, 2020
|
I added an untestable test in doc string 😅 Just fixed it now. |
|
Bump! |
ronisbr
added
feature
|
Triage is fine with this. I don't really see a downside. Can rebase and merge. |
simeonschaub
added
the
needs compat annotation
|
Nice! I will try to do this ASAP. I am currently in a place in which the Internet connection is very unstable. |
|
Done! |
ronisbr
removed
the
needs compat annotation
|
The failure in aarch64 is in the REPL tests and does not seem related to this PR. |
stevengj
added a commit
that referenced
this pull request
Dec 26, 2020
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* Arg. to avoid escaping backslahes (escape_string) This commit adds an argument to `escape_string` to assume that all backslashes (`\\`) are already escaped. Hence, `\\cdot` becomes `\\cdot` instead of `\\\\cdot`. The default value to this argument is `false`. Hence, this does not break any existing code since `escape_string` behaves exactly the same as before if no additional option is passed. Closes JuliaLang#34042 * Replace `bsescaped` arg. with `keep` keyword * Update NEWS.md * Fix doc tests * Add compat annotation Co-authored-by: Ronan Arraes Jardim Chagas <[email protected]>
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…on [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an argument to
escape_stringto assume that allbackslashes (
\\) are already escaped. Hence,\\cdotbecomes\\cdotinstead of
\\\\cdot.The default value to this argument is
false. Hence, this does notbreak any existing code since
escape_stringbehaves exactly the sameas before if no additional option is passed.
Closes #34042