improve inferrability of peek(::Stateful, sentinel)
#38625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the current inference can't propagate constant values or `isa` condition of object fields, and this helps inference eliminate the possibility of `getindex(s.nextvalstate::Nothing, 1)` call
4 tasks
Don't blame inference—this value is literally mutable |
vtjnash
changed the title
seek(::Stateful, sentinel)peek(::Stateful, sentinel)
timholy
approved these changes
Nov 30, 2020
|
There's a sense in which inference "seems like it should know," though I guess if it's not an atomic operation and might be modified externally, maybe inference is indeed doing what it should be doing. In any event, this is an effective way to address it. Thanks @aviatesk, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current inference can't propagate constant values or
isacondition of object fields, and this helps inference eliminate the
possibility of
getindex(s.nextvalstate::Nothing, 1)call