Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix markdown list rendering #40203

Merged
merged 1 commit into from
Mar 30, 2021
Merged

fix markdown list rendering #40203

merged 1 commit into from
Mar 30, 2021

Conversation

KristofferC
Copy link
Sponsor Member

Fixes #37232
Fixes JuliaDebug/Debugger.jl#287

Before, the wrapped_lines put things on different lines onto the same line:

julia> using Markdown

julia> md = @md_str """
       Misc:\\
       - `o`: open the current line in an editor\\
       """;

julia> str = sprint(io->Markdown.terminline(io, md.content[end].content))
"Misc:\n- o: open the current line in an editor\n"

julia> Markdown.wrapped_lines(stdout, str)
1-element Vector{AbstractString}:
 "Misc: - o: open the current line in an editor"

Now:

2-element Vector{String}:
 "Misc:"
 "- o: open the current line in an editor"

@KristofferC KristofferC added bugfix This change fixes an existing bug markdown backport 1.6 Change should be backported to release-1.6 labels Mar 26, 2021
@KristofferC KristofferC mentioned this pull request Mar 26, 2021
33 tasks
@KristofferC KristofferC merged commit 0f828a2 into master Mar 30, 2021
@KristofferC KristofferC deleted the kc/markdown_line_rendering branch March 30, 2021 12:19
KristofferC added a commit that referenced this pull request Apr 4, 2021
(cherry picked from commit 0f828a2)
KristofferC added a commit that referenced this pull request Apr 4, 2021
(cherry picked from commit 0f828a2)
KristofferC added a commit that referenced this pull request Apr 4, 2021
(cherry picked from commit 0f828a2)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 4, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression displaying help Changes in markdown rendering in console
1 participant