non-power-of-two atomic handling #41369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
multithreading
51 tasks
Alignment and sizes need to be carefully handled. Fixes #41219
|
Yes, that is what the merge-me tag means |
DilumAluthge
removed
the
merge me
KristofferC
pushed a commit
that referenced
this pull request
Jul 6, 2021
(cherry picked from commit 252ae69)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not handling non-power-of-two sizes, which is now fixed here. We always write trailing padding as zeros to minimize cmpswap failures (though we are tolerant of other values being present). In the future, we could consider potentially also extending that to all padding bytes being zeroed, but typically zeroinit is not the default, so it may not suffice to work.