dlopen() our libblas and liblapack within libjulia-internal
#41412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading our `libblas` and `liblapack` for the first time, we may need to rely upon an `RPATH` that has been embedded within `libjulia-internal`. If we use `libblastrampoline` to perform the actual `dlopen()`, however, we don't have that `RPATH` at hand. To fix this, we instead `dlopen()` the library first, to force the proper loading of the library (which loads the library and its `SONAME` into our process), which allows `libblastrampoline`'s `dlopen()` to immediately succeed, along the happy path of finding the library already loaded.
|
Fixes #41388 |
51 tasks
rashidrafeek
pushed a commit
to rashidrafeek/julia
that referenced
this pull request
Jul 2, 2021
…uliaLang#41412) When loading our `libblas` and `liblapack` for the first time, we may need to rely upon an `RPATH` that has been embedded within `libjulia-internal`. If we use `libblastrampoline` to perform the actual `dlopen()`, however, we don't have that `RPATH` at hand. To fix this, we instead `dlopen()` the library first, to force the proper loading of the library (which loads the library and its `SONAME` into our process), which allows `libblastrampoline`'s `dlopen()` to immediately succeed, along the happy path of finding the library already loaded.
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…uliaLang#41412) When loading our `libblas` and `liblapack` for the first time, we may need to rely upon an `RPATH` that has been embedded within `libjulia-internal`. If we use `libblastrampoline` to perform the actual `dlopen()`, however, we don't have that `RPATH` at hand. To fix this, we instead `dlopen()` the library first, to force the proper loading of the library (which loads the library and its `SONAME` into our process), which allows `libblastrampoline`'s `dlopen()` to immediately succeed, along the happy path of finding the library already loaded.
KristofferC
pushed a commit
that referenced
this pull request
Jul 5, 2021
…41412) When loading our `libblas` and `liblapack` for the first time, we may need to rely upon an `RPATH` that has been embedded within `libjulia-internal`. If we use `libblastrampoline` to perform the actual `dlopen()`, however, we don't have that `RPATH` at hand. To fix this, we instead `dlopen()` the library first, to force the proper loading of the library (which loads the library and its `SONAME` into our process), which allows `libblastrampoline`'s `dlopen()` to immediately succeed, along the happy path of finding the library already loaded. (cherry picked from commit 97a62dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41388
When loading our
libblasandliblapackfor the first time, we mayneed to rely upon an
RPATHthat has been embedded withinlibjulia-internal. If we uselibblastrampolineto perform theactual
dlopen(), however, we don't have thatRPATHat hand.To fix this, we instead
dlopen()the library first, to force theproper loading of the library (which loads the library and its
SONAMEinto our process), which allows
libblastrampoline'sdlopen()toimmediately succeed, along the happy path of finding the library already
loaded.