fix patch targets in openblas build (when not using binarybuilder) #41501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when building with USE_BINARYBUILDER=0
benlorenz
changed the title
|
CI won't catch these, because we don't test these build paths in the CI. The binaries are loaded from Yggdrasil. |
KristofferC
pushed a commit
that referenced
this pull request
Jul 19, 2021
when building with USE_BINARYBUILDER=0 (cherry picked from commit 19ecf00)
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to build master with
USE_BINARYBUILDER=0in Make.user fails with the following error:The dependencies for the make targets for the patches are wrong. I am slightly surprised that the CI didn't catch this.
This also applies to release-1.7.