-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI (Buildkite): move the sanitizers
builders (e.g. asan
) to the experimental pipeline
#41606
Conversation
One failure (https://buildkite.com/julialang/julia-master/builds/1975#60f9f268-e332-4ed7-b184-a3747c6f60e9/1072) is the same as #41571 (comment). Since this happens after the build is successful, we can simply turn off only the check script if it were the only issue. Two failures are due to
But I'm not sure where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunate but disabling this until we have a solution (or moving to the experimental pipeline) sounds good to me.
I don't have a good idea about how to debug generate_precompile.jl
running in the CI though. Maybe it'd be better if we dump the debug output in CI on failure:
julia/contrib/generate_precompile.jl
Lines 229 to 231 in 1c92e0d
function generate_precompile_statements() | |
start_time = time_ns() | |
debug_output = devnull # or stdout |
Let's do the experimental pipeline, instead of disabling it completely. I'll push those changes to this branch. |
sanitizers
builders (e.g. asan
)sanitizers
builders (e.g. asan
) to the experimental pipeline
Alright, I've moved it to the experimental pipeline instead of disabling it completely. |
…xperimental pipeline
f542e4b
to
b4685aa
Compare
@staticfloat Any idea what's going on with the failing
|
That happens when a job times out. |
It also happens if we have build cancellation enabled, so if you push to the same branch while it's running. |
I will also note that the experimental pipeline is reporting statuses to this PR; we probably don't want that. |
Ah yes I forgot to comment out the lines that post the status; I'll do that now. |
The |
So the differences are:
|
I think the problem was that I built I've built v2.0 of the Since the |
It did in fact fix things! https://buildkite.com/julialang/julia-master-experimental/builds/137 |
Since |
If you look at the last nine builds on master (https://buildkite.com/julialang/julia-master/builds?branch=master), the
asan
builder is failing in three of them.This PR moves it to the experimental pipeline.
So it will still run, but:
master
and PRs tomaster
. It won't run on pushes torelease-*
or PRs torelease-*
.