Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI (Buildkite): include the short commit hash in the artifact filename #41700

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge DilumAluthge added ci Continuous integration backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jul 25, 2021
@DilumAluthge DilumAluthge force-pushed the dpa/buildkite_artifact_short_commit branch 2 times, most recently from 15bb64b to 0ebb2b8 Compare July 25, 2021 09:18
@DilumAluthge DilumAluthge marked this pull request as ready for review July 25, 2021 09:21
@DilumAluthge DilumAluthge requested a review from a team as a code owner July 25, 2021 09:21
@DilumAluthge DilumAluthge requested review from staticfloat and removed request for a team July 25, 2021 09:21
@staticfloat
Copy link
Sponsor Member

Can we just use the same name that Julia itself would use? We can use “make print-JULIA_BINARYDIST_FILENAME” to figure it out.

@DilumAluthge
Copy link
Member Author

Can we just use the same name that Julia itself would use? We can use “make print-JULIA_BINARYDIST_FILENAME” to figure it out.

Sure, that's easy to do when uploading the artifact from the package builder.

But when we download the artifact from a different builder (e.g. the tester builder), we don't have make or the Julia source code. So we need to be able to construct the name of the artifact on the tester builder without running make.

@staticfloat
Copy link
Sponsor Member

staticfloat commented Jul 25, 2021 via email

@DilumAluthge DilumAluthge force-pushed the dpa/buildkite_artifact_short_commit branch from a8929b6 to be118c6 Compare July 26, 2021 00:32
@DilumAluthge
Copy link
Member Author

Looks like the make print-JULIA_BINARYDIST_FILENAME approach is working correctly.

@DilumAluthge DilumAluthge force-pushed the dpa/buildkite_artifact_short_commit branch from 99841d5 to dbba4a9 Compare July 26, 2021 01:29
@DilumAluthge DilumAluthge merged commit 343c2b1 into master Jul 26, 2021
@DilumAluthge DilumAluthge deleted the dpa/buildkite_artifact_short_commit branch July 26, 2021 01:42
KristofferC pushed a commit that referenced this pull request Jul 26, 2021
KristofferC pushed a commit that referenced this pull request Jul 26, 2021
@KristofferC KristofferC mentioned this pull request Jul 26, 2021
75 tasks
KristofferC pushed a commit that referenced this pull request Aug 31, 2021
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants