Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractUnitRange for setindex!,deleteat!,splice! #41809

Merged
merged 1 commit into from
Aug 20, 2021
Merged

AbstractUnitRange for setindex!,deleteat!,splice! #41809

merged 1 commit into from
Aug 20, 2021

Conversation

mkitti
Copy link
Contributor

@mkitti mkitti commented Aug 6, 2021 •
edited
Loading

Several methods could be generalized to work with AbstractUnitRange rather than just UnitRange. There are now several AbstractUnitRange subtypes:

julia> subtypes(AbstractUnitRange)
4-element Vector{Any}:
 Base.IdentityUnitRange
 Base.OneTo
 Base.Slice
 UnitRange

This PR allows setindex!, deleteat!, and splice! to be applied to Array and AbstractUnitRange.

@johnnychen94 johnnychen94 mentioned this pull request Aug 6, 2021
Merged
@mkitti mkitti marked this pull request as draft August 7, 2021 20:34
@mkitti mkitti mentioned this pull request Aug 7, 2021
Merged
@mkitti mkitti marked this pull request as ready for review August 17, 2021 00:44
@mkitti mkitti mentioned this pull request Aug 20, 2021
Merged
@vtjnash vtjnash merged commit 14e1ba0 into JuliaLang:master Aug 20, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@mkitti @LilithHafner
permit AbstractUnitRange for setindex!,deleteat!,splice! (JuliaLang#4…
6cf50b8 
…1809)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@mkitti @LilithHafner
permit AbstractUnitRange for setindex!,deleteat!,splice! (JuliaLang#4…
0e0395e 
…1809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkitti @vtjnash