show: improve typeinfo handling #42852
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures also that showing a Bool respects the compact flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to figure out if our typeinfo handling was correct, or if it could be improved (obviously, yes), so I added optional kwarg support to all
showmethods, and then tried to fix our usages of typeinfo based on that change. But I don't really like adding all of these kwargs, so I am thinking of changing this again to take a different approach, but keeping the fixes to the places that we are generating and using the information. Posting this now to get early feedback, if any.Ensures also that showing a
Boolrespects the compact flag.