Fix llvm powi intrinsic calls in fastmath.jl #44580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is OK for now, but this is now on my list of performance bugs to fix since we can do substantially better than LLVM here. |
|
The CI failures seem unrelated to the fastmath changes. |
KristofferC
pushed a commit
that referenced
this pull request
Jul 4, 2022
(cherry picked from commit b49a1b4)
KristofferC
pushed a commit
that referenced
this pull request
Jul 4, 2022
(cherry picked from commit b49a1b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is spotted by new verifyModule/verifyFunction asserts we make during our passes.