Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new :total_may_throw utility setting for @assume_effects #44775

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

aviatesk
Copy link
Sponsor Member

This setting is particularly useful since it allows the compiler to
evaluate a call of the applied method when all the call arguments are
fully known, no matter if the call results in an error or not.

@aviatesk aviatesk requested a review from Keno March 28, 2022 13:04
base/expr.jl Outdated Show resolved Hide resolved
@aviatesk aviatesk added the backport 1.8 Change should be backported to release-1.8 label Mar 30, 2022
@aviatesk aviatesk force-pushed the avi/44735 branch 2 times, most recently from 89dc2ab to 89d5071 Compare March 30, 2022 03:21
@aviatesk aviatesk changed the title add new :total_or_throw utility setting for @assume_effects add new :total_but_may_throw utility setting for @assume_effects Mar 30, 2022
@aviatesk aviatesk changed the base branch from avi/44735 to master March 30, 2022 03:39
@aviatesk aviatesk force-pushed the avi/total_or_error branch 4 times, most recently from ebad165 to d205a70 Compare April 1, 2022 01:52
@aviatesk aviatesk changed the title add new :total_but_may_throw utility setting for @assume_effects add new :total_may_throw utility setting for @assume_effects Apr 1, 2022
This setting is particularly useful since it allows the compiler to
evaluate a call of the applied method when all the call arguments are
fully known, no matter if the call results in an error or not.
@aviatesk
Copy link
Sponsor Member Author

aviatesk commented Apr 1, 2022

I also added some more explanations on the difference between @pure and @assume_effects.
May I ask your review on the change, @vtjnash ?

@aviatesk aviatesk merged commit 78d9dd0 into master Apr 1, 2022
@aviatesk aviatesk deleted the avi/total_or_error branch April 1, 2022 22:39
aviatesk added a commit that referenced this pull request Apr 1, 2022
)

This setting is particularly useful since it allows the compiler to
evaluate a call of the applied method when all the call arguments are
fully known, no matter if the call results in an error or not.

This commit also adds some more explanations on the difference between
`@pure` and `@assume_effects`.
@aviatesk aviatesk mentioned this pull request Apr 1, 2022
67 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants